From: David Miller <davem@davemloft.net>
To: hadarh@dev.mellanox.co.il
Cc: saeedm@mellanox.com, netdev@vger.kernel.org,
ogerlitz@mellanox.com, hadarh@mellanox.com
Subject: Re: [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode
Date: Tue, 26 Jul 2016 14:29:47 -0700 (PDT) [thread overview]
Message-ID: <20160726.142947.1063145474373793503.davem@davemloft.net> (raw)
In-Reply-To: <CAJL1qvFjWT4Bk_CdOdU7bECsh327nekVEFENmpU5vwFvNpMxLw@mail.gmail.com>
From: Hadar Hen Zion <hadarh@dev.mellanox.co.il>
Date: Tue, 26 Jul 2016 13:30:46 +0300
> In the default case eth_get_headlen() won't be called, it will happen
> only if PF administrator changes the mode from default to L4.
>
> In L4 mode, we need to copy all the packet headers including L4, do
> you know of a better/cheaper way for doing that?
You can just look straight at the ethernet header in this context.
eth_get_headlen() is expensive and has a complete header parser. It
is meant to be used when none of the SKB context state has been setup
yet (early RX processing before SKB is allocated, for example).
prev parent reply other threads:[~2016-07-26 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 13:12 [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode Saeed Mahameed
2016-07-24 13:12 ` [PATCH net-next V2 1/2] net/mlx5e: Check the minimum inline header mode before xmit Saeed Mahameed
2016-07-24 13:12 ` [PATCH net-next V2 2/2] net/mlx5e: Query minimum required header copy during xmit Saeed Mahameed
2016-07-26 0:54 ` [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode David Miller
2016-07-26 10:22 ` Hadar Hen Zion
2016-07-26 10:30 ` Hadar Hen Zion
2016-07-26 21:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726.142947.1063145474373793503.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadarh@dev.mellanox.co.il \
--cc=hadarh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).