From: David Miller <davem@davemloft.net>
To: phil.turnbull@oracle.com
Cc: netdev@vger.kernel.org, jchapman@katalix.com
Subject: Re: [PATCH net] l2tp: Correctly return -EBADF from pppol2tp_getname.
Date: Tue, 26 Jul 2016 15:19:57 -0700 (PDT) [thread overview]
Message-ID: <20160726.151957.1214443852703588578.davem@davemloft.net> (raw)
In-Reply-To: <20160726191435.31503-1-phil.turnbull@oracle.com>
From: Phil Turnbull <phil.turnbull@oracle.com>
Date: Tue, 26 Jul 2016 15:14:35 -0400
> If 'tunnel' is NULL we should return -EBADF but the 'end_put_sess' path
> unconditionally sets 'error' back to zero. Rework the error path so it
> more closely matches pppol2tp_sendmsg.
>
> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
> Signed-off-by: Phil Turnbull <phil.turnbull@oracle.com>
Applied.
prev parent reply other threads:[~2016-07-26 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 19:14 [PATCH net] l2tp: Correctly return -EBADF from pppol2tp_getname Phil Turnbull
2016-07-26 22:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726.151957.1214443852703588578.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=phil.turnbull@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).