netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alexmcwhirter@triadic.us
Cc: rlwinm@sdf.org, viro@zeniv.linux.org.uk, chunkeey@googlemail.com,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)
Date: Wed, 27 Jul 2016 16:45:43 -0700 (PDT)	[thread overview]
Message-ID: <20160727.164543.1466564919313003461.davem@davemloft.net> (raw)
In-Reply-To: <87c4ed555bcb4229f2334f6f2bb69bcb@triadic.us>

From: alexmcwhirter@triadic.us
Date: Wed, 27 Jul 2016 19:02:40 -0400

> On 2016-07-27 14:04, alexmcwhirter@triadic.us wrote:
>> Just to add some more information to this, the corruption seems to
>> effect ssh as well.
>> Using a sun hme interface, occasionally upon an ssh connection it will
>> refuse to authenticate a client with either password or cert
>> authentication. Using wireshark to capture and decrypt the packets
>> between the two machines, the data coming from the server seems good,
>> but the data received by the server from the client is essentially
>> garbage. Note that the client is sending valid data, but the server is
>> corrupting it upon receipt. Closing the connection and starting a new
>> one will remedy the login issue, but you do occasionally see
>> corruption on the server side sporadically.
>> So far this only seems to occur on incoming data, outgoing data seems
>> fine.
> 
> Also, there is another patch the references this commit on sparc64 at
> least.
> 
> https://patchwork.kernel.org/patch/9221895/
> 
> I highly expect both my issue and OP's issue to revolve not around
> commit e5a4b0bb803b specifically, but around other code that no longer
> behaves as expected because of it.

Indeed, and that fault address rounding bug occurs two other times
in arch/sparc/lib/user_fixup.c

The mentioned patchwork patch should fix the bug and I'll get that
into my sparc tree, merged, and queued up for -stable ASAP.

  reply	other threads:[~2016-07-27 23:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24  3:35 PROBLEM: network data corruption (bisected to e5a4b0bb803b) Alan Curry
     [not found] ` <201607240335.u6O3ZE81014171-WF+c3Tt1nJM@public.gmane.org>
2016-07-24 17:45   ` Christian Lamparter
2016-07-24 19:02     ` Al Viro
2016-07-26  4:57       ` Alan Curry
2016-07-26 13:59         ` Christian Lamparter
2016-07-26 18:15           ` alexmcwhirter
2016-07-27  6:39             ` Kalle Valo
2016-07-27  1:14           ` Alan Curry
2016-07-27 10:32       ` Alan Curry
2016-07-27 18:04         ` alexmcwhirter
2016-07-27 23:02           ` alexmcwhirter
2016-07-27 23:45             ` David Miller [this message]
2016-07-28  0:31               ` Al Viro
2016-07-28  0:26                 ` alexmcwhirter
     [not found]                   ` <8b3126f66186015956e0f8090fb70532-O8/uFoRGvHWcqzYg7KEe8g@public.gmane.org>
2016-07-28  1:22                     ` Al Viro
2016-08-03  3:49                       ` Alan Curry
2016-08-03 12:43                         ` Christian Lamparter
2016-08-03 23:25                           ` Alan Curry
     [not found]                         ` <20160803054118.GG2356@ZenIV.linux.org.uk>
     [not found]                           ` <2363167.YiBS7sFNO2@debian64>
     [not found]                             ` <20160809145836.GQ2356@ZenIV.linux.org.uk>
     [not found]                               ` <20170210081126.GA14157@ZenIV.linux.org.uk>
2017-02-10 21:45                                 ` Al Viro
2017-02-11 19:37                                   ` Christian Lamparter
2017-02-12  5:42                                     ` Al Viro
2017-02-13 21:56                                       ` Christian Lamparter
2017-02-14  1:33                                         ` [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al. (was Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)) Al Viro
2017-02-17 15:54                                           ` [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al David Miller
2017-02-17 17:03                                             ` Al Viro
2017-02-18  0:02                                               ` Al Viro
2017-02-18  2:24                                                 ` Al Viro
2017-02-19 19:19                                                 ` Christian Lamparter
2017-02-20 15:14                                                 ` David Miller
2017-02-21 13:25                                                 ` David Laight
2016-07-26  4:32     ` PROBLEM: network data corruption (bisected to e5a4b0bb803b) Alan Curry
2016-07-26  4:38     ` alexmcwhirter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160727.164543.1466564919313003461.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexmcwhirter@triadic.us \
    --cc=chunkeey@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rlwinm@sdf.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).