From: Steffen Klassert <steffen.klassert@secunet.com>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting
Date: Thu, 28 Jul 2016 06:57:47 +0200 [thread overview]
Message-ID: <20160728045747.GH5710@gauss.secunet.com> (raw)
In-Reply-To: <57984EA6.3040205@oracle.com>
On Wed, Jul 27, 2016 at 08:03:18AM +0200, Vegard Nossum wrote:
> Subject: [PATCH] xfrm: get rid of incorrect WARN
>
> AFAICT this message is just printed whenever input validation fails.
> This is a normal failure and we shouldn't be dumping the stack over it.
>
> Looks like it was originally a printk that was maybe incorrectly
> upgraded to a WARN:
>
> commit 62db5cfd70b1ef53aa21f144a806fe3b78c84fab
> Author: stephen hemminger <shemminger@vyatta.com>
> Date: Wed May 12 06:37:06 2010 +0000
>
> xfrm: add severity to printk
>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Applied to the ipsec tree, thanks!
prev parent reply other threads:[~2016-07-28 4:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 8:32 [PATCH] xfrm: use printk instead of WARN for bad policy reporting Vegard Nossum
2016-07-20 11:53 ` Vegard Nossum
2016-07-27 3:01 ` Herbert Xu
2016-07-27 6:20 ` Vegard Nossum
2016-07-27 6:31 ` Herbert Xu
2016-07-27 6:44 ` Vegard Nossum
2016-07-28 4:58 ` Steffen Klassert
2016-07-20 12:15 ` Steffen Klassert
2016-07-27 6:03 ` Vegard Nossum
2016-07-28 4:57 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728045747.GH5710@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).