From: Tejun Heo <tj@kernel.org>
To: Saeed Mahameed <saeedm@dev.mellanox.co.il>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Linux Netdev List <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue
Date: Fri, 29 Jul 2016 08:25:16 -0400 [thread overview]
Message-ID: <20160729122516.GH2542@mtj.duckdns.org> (raw)
In-Reply-To: <CALzJLG_B4q2TeAy9U+8nZisYtw8+MfwT8or81mBsPJ=VFLxBqw@mail.gmail.com>
Hello,
On Fri, Jul 29, 2016 at 01:30:05AM +0300, Saeed Mahameed wrote:
> > Are the workitems being used on a memory reclaim path?
>
> do you mean they need to allocate memory ?
It's a bit convoluted. A workqueue needs WQ_MEM_RECLAIM flag to be
guaranteed forward progress under memory pressure, so any workqueue
which may be depended upon during memory reclaim should have the flag
set; otherwise, the system can deadlock (try to reclaim memory, hits
the wq which can't make forward progress due to lack of memory). For
network devices, the requirement comes from block-over-network or nfs
which can be involved in memory reclaim.
Thanks.
--
tejun
prev parent reply other threads:[~2016-07-29 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 6:12 [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue Bhaktipriya Shridhar
2016-07-28 22:30 ` Saeed Mahameed
2016-07-29 12:25 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729122516.GH2542@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=bhaktipriya96@gmail.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).