From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware) Date: Fri, 29 Jul 2016 14:02:24 -0700 Message-ID: <20160729140224.137dbaac@xeon-e3> References: <1469693721-5641-1-git-send-email-amir.jer.levy@intel.com> <1469693721-5641-5-git-send-email-amir.jer.levy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: andreas.noever@gmail.com, gregkh@linuxfoundation.org, bhelgaas@google.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, thunderbolt-linux@intel.com, mika.westerberg@intel.com, tomas.winkler@intel.com To: Amir Levy Return-path: In-Reply-To: <1469693721-5641-5-git-send-email-amir.jer.levy@intel.com> Sender: linux-pci-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 28 Jul 2016 11:15:17 +0300 Amir Levy wrote: > +static LIST_HEAD(controllers_list); > +static DECLARE_RWSEM(controllers_list_rwsem); Why use a semaphore when simple spinlock or mutex would be better?