* [PATCH 1/1] qed: do not use unitialized variable
@ 2016-07-31 11:24 Heinrich Schuchardt
2016-07-31 11:34 ` Yuval Mintz
2016-08-01 20:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2016-07-31 11:24 UTC (permalink / raw)
To: Yuval Mintz, Ariel Elior, everest-linux-l2
Cc: netdev, linux-kernel, Heinrich Schuchardt
Do not write random bytes from the kernel stack when
calling qed_wr.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/ethernet/qlogic/qed/qed_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index b26fe26..151cbf9 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -888,7 +888,7 @@ static int qed_hw_init_pf(struct qed_hwfn *p_hwfn,
if (hw_mode & (1 << MODE_MF_SI)) {
u8 pf_id = 0;
- u32 val;
+ u32 val = 0;
if (!qed_hw_init_first_eth(p_hwfn, p_ptt, &pf_id)) {
if (p_hwfn->rel_pf_id == pf_id) {
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH 1/1] qed: do not use unitialized variable
2016-07-31 11:24 [PATCH 1/1] qed: do not use unitialized variable Heinrich Schuchardt
@ 2016-07-31 11:34 ` Yuval Mintz
2016-08-01 20:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Yuval Mintz @ 2016-07-31 11:34 UTC (permalink / raw)
To: Heinrich Schuchardt, David Miller; +Cc: netdev, linux-kernel, Ariel Elior
> Do not write random bytes from the kernel stack when calling qed_wr.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Thanks.
Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] qed: do not use unitialized variable
2016-07-31 11:24 [PATCH 1/1] qed: do not use unitialized variable Heinrich Schuchardt
2016-07-31 11:34 ` Yuval Mintz
@ 2016-08-01 20:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-08-01 20:45 UTC (permalink / raw)
To: xypron.glpk
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, linux-kernel
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sun, 31 Jul 2016 13:24:52 +0200
> Do not write random bytes from the kernel stack when
> calling qed_wr.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-01 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-31 11:24 [PATCH 1/1] qed: do not use unitialized variable Heinrich Schuchardt
2016-07-31 11:34 ` Yuval Mintz
2016-08-01 20:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).