From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH 1084/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 09:27:31 -0400 Message-ID: <20160802092731.3e5c65e1@gandalf.local.home> References: <20160802121502.22394-1-baolex.ni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jiangshanlai@gmail.com, mathieu.desnoyers@efficios.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, oleg@redhat.com, gang.chen.5i5j@gmail.com, mhocko@suse.com, koct9i@gmail.com, aarcange@redhat.com, aryabinin@virtuozzo.com To: Baole Ni Return-path: Received: from smtprelay0046.hostedemail.com ([216.40.44.46]:33858 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966048AbcHBNrY (ORCPT ); Tue, 2 Aug 2016 09:47:24 -0400 In-Reply-To: <20160802121502.22394-1-baolex.ni@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2 Aug 2016 20:15:02 +0800 Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > net/802/mrp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/802/mrp.c b/net/802/mrp.c > index 72db278..4ff215f 100644 > --- a/net/802/mrp.c > +++ b/net/802/mrp.c > @@ -22,11 +22,11 @@ > #include > > static unsigned int mrp_join_time __read_mostly = 200; > -module_param(mrp_join_time, uint, 0644); > +module_param(mrp_join_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(mrp_join_time, "Join time in ms (default 200ms)"); > > static unsigned int mrp_periodic_time __read_mostly = 1000; > -module_param(mrp_periodic_time, uint, 0644); > +module_param(mrp_periodic_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(mrp_periodic_time, "Periodic time in ms (default 1s)"); > > MODULE_LICENSE("GPL");