From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baole Ni Subject: [PATCH 0746/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:42:14 +0800 Message-ID: <20160802114214.31794-1-baolex.ni@intel.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, jesse@kernel.org, linville@tuxdriver.com, pshelar@nicira.com, jbenc@redhat.com, daniel@iogearbox.net, hannes@stressinduktion.org, tom@herbertland.com, aduyck@mirantis.com, chuansheng.liu@intel.com, baolex.ni@intel.com To: michal.simek@xilinx.com, soren.brinkmann@xilinx.com, bkenward@solarflare.com, linux-driver@qlogic.com, computersforpeace@gmail.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Return-path: Received: from mga14.intel.com ([192.55.52.115]:9329 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934502AbcHBMT6 (ORCPT ); Tue, 2 Aug 2016 08:19:58 -0400 Sender: netdev-owner@vger.kernel.org List-ID: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index cadefe4..2ddaa09 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -32,7 +32,7 @@ #define VNI_HASH_SIZE (1<