* [PATCH 1083/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:14 Baole Ni
2016-08-02 13:27 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 12:14 UTC (permalink / raw)
To: davem, jiangshanlai, rostedt, mathieu.desnoyers, m.chehab, gregkh,
m.szyprowski, kyungmin.park, k.kozlowski
Cc: netdev, linux-kernel, chuansheng.liu, baolex.ni, oleg,
gang.chen.5i5j, mhocko, koct9i, aarcange, aryabinin
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
net/802/garp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/802/garp.c b/net/802/garp.c
index b38ee6d..ecc976a 100644
--- a/net/802/garp.c
+++ b/net/802/garp.c
@@ -22,7 +22,7 @@
#include <asm/unaligned.h>
static unsigned int garp_join_time __read_mostly = 200;
-module_param(garp_join_time, uint, 0644);
+module_param(garp_join_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(garp_join_time, "Join time in ms (default 200ms)");
MODULE_LICENSE("GPL");
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1083/1285] Replace numeric parameter like 0444 with macro
2016-08-02 12:14 [PATCH 1083/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 13:27 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2016-08-02 13:27 UTC (permalink / raw)
To: Baole Ni
Cc: davem, jiangshanlai, mathieu.desnoyers, m.chehab, gregkh,
m.szyprowski, kyungmin.park, k.kozlowski, netdev, linux-kernel,
chuansheng.liu, oleg, gang.chen.5i5j, mhocko, koct9i, aarcange,
aryabinin
On Tue, 2 Aug 2016 20:14:55 +0800
Baole Ni <baolex.ni@intel.com> wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
NACK!
I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH.
-- Steve
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> net/802/garp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/802/garp.c b/net/802/garp.c
> index b38ee6d..ecc976a 100644
> --- a/net/802/garp.c
> +++ b/net/802/garp.c
> @@ -22,7 +22,7 @@
> #include <asm/unaligned.h>
>
> static unsigned int garp_join_time __read_mostly = 200;
> -module_param(garp_join_time, uint, 0644);
> +module_param(garp_join_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(garp_join_time, "Join time in ms (default 200ms)");
> MODULE_LICENSE("GPL");
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-02 12:14 [PATCH 1083/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 13:27 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).