netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1139/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:19 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 12:19 UTC (permalink / raw)
  To: bfields, jlayton, trond.myklebust, anna.schumaker, davem, kadlec,
	m.szyprowski, kyungmin.park, k.kozlowski
  Cc: linux-nfs, netdev, linux-kernel, chuansheng.liu, baolex.ni, arnd,
	aryabinin

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 net/sunrpc/xprtsock.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 7e2b2fa..51dec63 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -3166,8 +3166,8 @@ static const struct kernel_param_ops param_ops_portnr = {
 #define param_check_portnr(name, p) \
 	__param_check(name, p, unsigned int);
 
-module_param_named(min_resvport, xprt_min_resvport, portnr, 0644);
-module_param_named(max_resvport, xprt_max_resvport, portnr, 0644);
+module_param_named(min_resvport, xprt_min_resvport, portnr, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_named(max_resvport, xprt_max_resvport, portnr, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 static int param_set_slot_table_size(const char *val,
 				     const struct kernel_param *kp)
@@ -3202,9 +3202,9 @@ static const struct kernel_param_ops param_ops_max_slot_table_size = {
 	__param_check(name, p, unsigned int);
 
 module_param_named(tcp_slot_table_entries, xprt_tcp_slot_table_entries,
-		   slot_table_size, 0644);
+		   slot_table_size, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 module_param_named(tcp_max_slot_table_entries, xprt_max_tcp_slot_table_entries,
-		   max_slot_table_size, 0644);
+		   max_slot_table_size, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 module_param_named(udp_slot_table_entries, xprt_udp_slot_table_entries,
-		   slot_table_size, 0644);
+		   slot_table_size, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
-- 
2.9.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 12:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-02 12:19 [PATCH 1139/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).