From: Phil Sutter <phil@nwl.cc>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Xin Long <lucien.xin@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/3] sctp_diag: export timer value only if it is active
Date: Thu, 4 Aug 2016 01:39:32 +0200 [thread overview]
Message-ID: <20160803233652.4709D647E4@mail.nwl.cc> (raw)
In-Reply-To: <20160803215115.GE2954@localhost.localdomain>
On Wed, Aug 03, 2016 at 06:51:15PM -0300, Marcelo Ricardo Leitner wrote:
> On Wed, Aug 03, 2016 at 11:23:12PM +0200, Phil Sutter wrote:
> > Since it is exported as unsigned value, userspace has no way detecting
> > whether it is negative or just very large. Therefore do this in kernel
> > space where it is a simple comparison.
> >
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
> > ---
> > Changes since v1:
> > - Introduce local variable to shorten long lines.
> > - Use timer_pending() to decide whether to export the timer value.
> > - Export the primary path's value instead of garbage.
>
> This is now the most important change on the patch IMO. Can we mention
> it on changelog itself?
>
> A Fixes tag is welcomed too, as previous values were incorrect.
Oh right, thanks for pointing this out. I will follow-up with a fixed
v3.
Thanks, Phil
next prev parent reply other threads:[~2016-08-03 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 21:23 [PATCH v2 0/3] sctp_diag: A bunch of fixes for upcoming 'ss' support Phil Sutter
2016-08-03 21:23 ` [PATCH v2 1/3] sctp: Export struct sctp_info to userspace Phil Sutter
2016-08-04 9:13 ` David Laight
2016-08-04 9:27 ` Phil Sutter
2016-08-04 12:16 ` Xin Long
2016-08-03 21:23 ` [PATCH v2 2/3] sctp_diag: export timer value only if it is active Phil Sutter
2016-08-03 21:51 ` Marcelo Ricardo Leitner
2016-08-03 23:39 ` Phil Sutter [this message]
2016-08-03 21:23 ` [PATCH v2 3/3] sctp_diag: Respect ss adding TCPF_CLOSE to idiag_states Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803233652.4709D647E4@mail.nwl.cc \
--to=phil@nwl.cc \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).