netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tom Herbert <tom@herbertland.com>
Cc: Stephen Hemminger <shemming@Brocade.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH iproute v2 2/5] ila: Support for configuring ila to use netfilter hook
Date: Sat, 6 Aug 2016 10:33:46 -0700	[thread overview]
Message-ID: <20160806103346.56f7c33a@xeon-e3> (raw)
In-Reply-To: <269381334f4e4f2e9a40dd3f91129234@HQ1WP-EXMB11.corp.brocade.com>

I have no problem with this series in general and wanted to put it in before
closing the lid on 4.7 version, BUT.

This patch generates warnings when built on Debian Strech with gcc-5
 
ipila.c: In function ‘ila_parse_opt.constprop’:
ipila.c:205:2: warning: ‘locator_match’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);

	if (matches(*argv, "add") == 0)
> +		return do_add(argc-1, argv+1);
> +	if (matches(*argv, "delete") == 0)
> +		return do_del(argc-1, argv+1);
> +	if (matches(*argv, "list") == 0)
> +		return do_list(argc-1, argv+1);
> +	if (matches(*argv, "help") == 0)
> +		usage();
> +
> +	fprintf(stderr, "Command \"%s\" is unknown, try \"ip ila help\".\n",
> +		*argv);
> +	exit(-1);
> +}
> +

You also added a blank line at end of file.

Please fix this and resubmit the series.

      parent reply	other threads:[~2016-08-06 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 20:34 [PATCH iproute v2 0/5] iproute: ila and fou addition Tom Herbert
2016-08-04 20:34 ` [PATCH iproute v2 1/5] ila: Support for checksum neutral translation Tom Herbert
2016-08-04 20:34 ` [PATCH iproute v2 2/5] ila: Support for configuring ila to use netfilter hook Tom Herbert
2016-08-04 20:34 ` [PATCH iproute v2 3/5] ip6tnl: Support for fou encapsulation Tom Herbert
2016-08-04 20:34 ` [PATCH iproute v2 4/5] gre6: " Tom Herbert
2016-08-04 20:34 ` [PATCH iproute v2 5/5] fou: Allowing configuring IPv6 listener Tom Herbert
     [not found] ` <269381334f4e4f2e9a40dd3f91129234@HQ1WP-EXMB11.corp.brocade.com>
2016-08-06 17:33   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160806103346.56f7c33a@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemming@Brocade.com \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).