* [PATCH] tc/m_gact: Fix action_a2n() return code check
@ 2016-08-07 11:19 Phil Sutter
2016-08-08 15:55 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2016-08-07 11:19 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Mark Bloch, netdev
The function returns zero on success.
Reported-by: Mark Bloch <markb@mellanox.com>
Fixes: 69f5aff63c770b ("tc: use action_a2n() everywhere")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
tc/m_gact.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/m_gact.c b/tc/m_gact.c
index c0a938c716b6a..2bfd9a7c317e4 100644
--- a/tc/m_gact.c
+++ b/tc/m_gact.c
@@ -73,7 +73,7 @@ get_act(char ***argv_p)
{
int n;
- if (!action_a2n(**argv_p, &n, false)) {
+ if (action_a2n(**argv_p, &n, false)) {
fprintf(stderr, "bad action type %s\n", **argv_p);
return -10;
}
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tc/m_gact: Fix action_a2n() return code check
2016-08-07 11:19 [PATCH] tc/m_gact: Fix action_a2n() return code check Phil Sutter
@ 2016-08-08 15:55 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2016-08-08 15:55 UTC (permalink / raw)
To: Phil Sutter; +Cc: Mark Bloch, netdev
On Sun, 7 Aug 2016 13:19:01 +0200
Phil Sutter <phil@nwl.cc> wrote:
> The function returns zero on success.
>
> Reported-by: Mark Bloch <markb@mellanox.com>
> Fixes: 69f5aff63c770b ("tc: use action_a2n() everywhere")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-08 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-07 11:19 [PATCH] tc/m_gact: Fix action_a2n() return code check Phil Sutter
2016-08-08 15:55 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).