From: David Miller <davem@davemloft.net>
To: hejianet@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net
Subject: Re: [RFC PATCH 2/3] net: Replace for_each_possible_cpu with for_each_online_cpu
Date: Mon, 08 Aug 2016 10:59:08 -0700 (PDT) [thread overview]
Message-ID: <20160808.105908.301414649577514579.davem@davemloft.net> (raw)
In-Reply-To: <1470651742-15195-3-git-send-email-hejianet@gmail.com>
From: Jia He <hejianet@gmail.com>
Date: Mon, 8 Aug 2016 18:22:21 +0800
> In PowerPC server with large number cpus, the loop index in smt=1 could be
> reduced to 1/8 compared with smt=8.
> Thus cache misses can be reduced.
You can't do this, if cpus go down we still want to report the statistics
they collected while they were up.
So we must use the possible cpu list here.
next prev parent reply other threads:[~2016-08-08 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 10:22 [RFC PATCH 0/3] net: Improve snmp6_fill_stats Jia He
2016-08-08 10:22 ` [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64 Jia He
2016-08-08 11:12 ` Florian Westphal
2016-08-08 13:04 ` hejianet
2016-08-09 10:12 ` Eric Dumazet
2016-08-08 10:22 ` [RFC PATCH 2/3] net: Replace for_each_possible_cpu with for_each_online_cpu Jia He
2016-08-08 17:59 ` David Miller [this message]
2016-08-09 10:10 ` Eric Dumazet
2016-08-08 10:22 ` [RFC PATCH 3/3] net: Remove the useless parameter of __snmp6_fill_statsdev Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808.105908.301414649577514579.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hejianet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).