From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: netdev@vger.kernel.org, hannes@stressinduktion.org,
ek@google.com, hideaki.yoshifuji@miraclelinux.com
Subject: Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.
Date: Mon, 08 Aug 2016 14:35:00 -0700 (PDT) [thread overview]
Message-ID: <20160808.143500.473355495580691289.davem@davemloft.net> (raw)
In-Reply-To: <1470642127-574-1-git-send-email-lorenzo@google.com>
From: Lorenzo Colitti <lorenzo@google.com>
Date: Mon, 8 Aug 2016 16:42:07 +0900
> ping_v6_sendmsg never sets flowi6_oif, so it is not possible to
> ping an IPv6 address on a different interface. Instead, it sets
> flowi6_iif, which is incorrect but harmless. Also, it returns an
> error if a passed-in scope ID doesn't match sk_bound_dev_if.
>
> Get rid of the error, stop setting flowi6_iif, and support
> various ways of setting oif in the same priority order used by
> udpv6_sendmsg.
>
> Tested: https://android-review.googlesource.com/#/c/254470/
> Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
We should always give sk_bound_dev_if the highest priority.
Also, we should amend, not delete, the check against the scope
ID in the sockaddr. As explained by YOSHIFUJI Hideaki.
next prev parent reply other threads:[~2016-08-08 21:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 7:42 [PATCH net] net: ipv6: Fix ping to link-local addresses Lorenzo Colitti
2016-08-08 14:26 ` Hannes Frederic Sowa
2016-08-08 14:45 ` Lorenzo Colitti
2016-08-08 16:22 ` 吉藤英明
2016-08-08 15:27 ` David Ahern
2016-08-08 16:24 ` Lorenzo Colitti
2016-08-08 16:27 ` David Ahern
2016-08-09 0:40 ` Lorenzo Colitti
2016-08-08 21:35 ` David Miller [this message]
2016-08-09 1:00 ` Lorenzo Colitti
2016-08-09 5:20 ` David Miller
2016-08-09 7:01 ` Erik Kline
2016-08-09 8:37 ` YOSHIFUJI Hideaki
2016-08-09 9:36 ` Hannes Frederic Sowa
2016-08-09 11:42 ` Lorenzo Colitti
2016-08-09 13:21 ` David Ahern
2016-08-09 22:44 ` YOSHIFUJI Hideaki
2016-08-12 15:45 ` Lorenzo Colitti
2016-08-12 16:04 ` David Ahern
2016-08-15 7:39 ` YOSHIFUJI Hideaki
2016-08-16 15:21 ` Lorenzo Colitti
2016-08-16 16:22 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808.143500.473355495580691289.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ek@google.com \
--cc=hannes@stressinduktion.org \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).