From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
eladr@mellanox.com, yotamg@mellanox.com, nogahf@mellanox.com,
ogerlitz@mellanox.com
Subject: Re: [patch iproute2 1/2] devlink: write usage help messages to stderr
Date: Mon, 8 Aug 2016 08:56:54 -0700 [thread overview]
Message-ID: <20160808085654.764550e2@xeon-e3> (raw)
In-Reply-To: <20160808071921.GA1944@nanopsycho.orion>
On Mon, 8 Aug 2016 09:19:21 +0200
Jiri Pirko <jiri@resnulli.us> wrote:
> Sat, Jul 23, 2016 at 06:46:59PM CEST, stephen@networkplumber.org wrote:
> >On Fri, 22 Jul 2016 18:34:29 +0200
> >Jiri Pirko <jiri@resnulli.us> wrote:
> >
> >> From: Jiri Pirko <jiri@mellanox.com>
> >>
> >> In order to not confuse reader, write help messages into stderr.
> >>
> >> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> >
> >This does make devlink consistent with other parts of iproute2.
> >But the most common coding standards, back to Unix, and GNU are
> >that help messages should go to stdout so that:
> > $ ip -h | more
> >would work as expected.
>
> The thing is I wanted to make stdout only for json. Putting non-json
> help out there does not look correct to me. Is it?
>
I applied both of these patches, just wanted to mention that iproute2 is not
following the GNU convention. At this point, it really doesn't matter, there
are arguments to be made for both behaviors.
next prev parent reply other threads:[~2016-08-08 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 16:34 [patch iproute2 1/2] devlink: write usage help messages to stderr Jiri Pirko
2016-07-22 16:34 ` [patch iproute2 2/2] devlink: add option to generate JSON output Jiri Pirko
2016-07-23 16:46 ` [patch iproute2 1/2] devlink: write usage help messages to stderr Stephen Hemminger
2016-08-08 7:19 ` Jiri Pirko
2016-08-08 15:56 ` Stephen Hemminger [this message]
2016-08-08 16:18 ` Jiri Pirko
2016-08-09 10:34 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808085654.764550e2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox