From: Florian Westphal <fw@strlen.de>
To: Jia He <hejianet@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64
Date: Mon, 8 Aug 2016 13:12:31 +0200 [thread overview]
Message-ID: <20160808111231.GA20192@breakpoint.cc> (raw)
In-Reply-To: <1470651742-15195-2-git-send-email-hejianet@gmail.com>
Jia He <hejianet@gmail.com> wrote:
> buff[] will be assigned later, so memset is not necessary.
>
> Signed-off-by: Jia He <hejianet@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> Cc: James Morris <jmorris@namei.org>
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Cc: Patrick McHardy <kaber@trash.net>
> ---
> net/ipv6/addrconf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index ab3e796..43fa8d0 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -4967,7 +4967,6 @@ static inline void __snmp6_fill_stats64(u64 *stats, void __percpu *mib,
>
> BUG_ON(pad < 0);
>
> - memset(buff, 0, sizeof(buff));
> buff[0] = IPSTATS_MIB_MAX;
>
> for_each_possible_cpu(c) {
for (i = 1; i < IPSTATS_MIB_MAX; i++)
buff[i] += snmp_get_cpu_field64(mib, c, i, syncpoff);
Without memset result of buff[i] += ... is undefined.
next prev parent reply other threads:[~2016-08-08 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 10:22 [RFC PATCH 0/3] net: Improve snmp6_fill_stats Jia He
2016-08-08 10:22 ` [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64 Jia He
2016-08-08 11:12 ` Florian Westphal [this message]
2016-08-08 13:04 ` hejianet
2016-08-09 10:12 ` Eric Dumazet
2016-08-08 10:22 ` [RFC PATCH 2/3] net: Replace for_each_possible_cpu with for_each_online_cpu Jia He
2016-08-08 17:59 ` David Miller
2016-08-09 10:10 ` Eric Dumazet
2016-08-08 10:22 ` [RFC PATCH 3/3] net: Remove the useless parameter of __snmp6_fill_statsdev Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808111231.GA20192@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=hejianet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).