From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch iproute2 1/2] devlink: write usage help messages to stderr Date: Mon, 8 Aug 2016 18:18:22 +0200 Message-ID: <20160808161822.GK1944@nanopsycho.orion> References: <1469205270-6180-1-git-send-email-jiri@resnulli.us> <20160723094659.06921b95@xeon-e3> <20160808071921.GA1944@nanopsycho.orion> <20160808085654.764550e2@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com To: Stephen Hemminger Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:32903 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752313AbcHHQSa (ORCPT ); Mon, 8 Aug 2016 12:18:30 -0400 Received: by mail-wm0-f68.google.com with SMTP id o80so16446504wme.0 for ; Mon, 08 Aug 2016 09:18:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160808085654.764550e2@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Aug 08, 2016 at 05:56:54PM CEST, stephen@networkplumber.org wrote: >On Mon, 8 Aug 2016 09:19:21 +0200 >Jiri Pirko wrote: > >> Sat, Jul 23, 2016 at 06:46:59PM CEST, stephen@networkplumber.org wrote: >> >On Fri, 22 Jul 2016 18:34:29 +0200 >> >Jiri Pirko wrote: >> > >> >> From: Jiri Pirko >> >> >> >> In order to not confuse reader, write help messages into stderr. >> >> >> >> Signed-off-by: Jiri Pirko >> > >> >This does make devlink consistent with other parts of iproute2. >> >But the most common coding standards, back to Unix, and GNU are >> >that help messages should go to stdout so that: >> > $ ip -h | more >> >would work as expected. >> >> The thing is I wanted to make stdout only for json. Putting non-json >> help out there does not look correct to me. Is it? >> > >I applied both of these patches, just wanted to mention that iproute2 is not >following the GNU convention. At this point, it really doesn't matter, there >are arguments to be made for both behaviors. Allright. Thanks.