From: David Miller <davem@davemloft.net>
To: jikos@kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: qdisc hash table changes...
Date: Tue, 09 Aug 2016 01:54:17 -0700 (PDT) [thread overview]
Message-ID: <20160809.015417.214949723922909511.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1608090936180.22028@cbobk.fhfr.pm>
From: Jiri Kosina <jikos@kernel.org>
Date: Tue, 9 Aug 2016 09:42:01 +0200 (CEST)
> It does indirectly pull in some networking headers, but it doesn't pull in
> netdevice.h (which is the place where the actual include of hashtable.h
> happens):
It pulls in skbuff.h, so are you willing to bet forever that skbuff.h
won't indirectly pull in netdevice.h at some point in the future?
This is obviously a big problem, having global namespace conflicts
like this.
Pushing fixing it propering into the future isn't really the right
thing to do.
So please entertain my request to do this properly.
Thank you.
next prev parent reply other threads:[~2016-08-09 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 22:53 qdisc hash table changes David Miller
2016-08-09 7:42 ` Jiri Kosina
2016-08-09 8:54 ` David Miller [this message]
2016-08-09 9:02 ` Jiri Kosina
2016-08-10 5:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809.015417.214949723922909511.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jikos@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).