From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net-next v3 1/3] strparser: Stream parser for messages
Date: Tue, 09 Aug 2016 16:14:56 -0700 (PDT) [thread overview]
Message-ID: <20160809.161456.360128105313384145.davem@davemloft.net> (raw)
In-Reply-To: <1470086929-3666623-2-git-send-email-tom@herbertland.com>
From: Tom Herbert <tom@herbertland.com>
Date: Mon, 1 Aug 2016 14:28:47 -0700
> +/* Lower lock held */
> +void strp_parser_err(struct strparser *strp, int err, read_descriptor_t *desc)
> +{
> + desc->error = err;
> + kfree_skb(strp->rx_skb_head);
> + strp->rx_skb_head = NULL;
> + strp_abort_rx_strp(strp, err);
> +}
Unused outside of this file, please mark "static".
> +void strp_queue_work(struct strparser *strp)
> +{
> + queue_work(strp_wq, &strp->rx_work);
> +}
Completely unused, please remove.
Thanks.
next prev parent reply other threads:[~2016-08-09 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 21:28 [PATCH net-next v3 0/3] strp: Stream parser for messages Tom Herbert
2016-08-01 21:28 ` [PATCH net-next v3 1/3] strparser: " Tom Herbert
2016-08-09 23:14 ` David Miller [this message]
2016-08-01 21:28 ` [PATCH net-next v3 2/3] kcm: Use stream parser Tom Herbert
2016-08-01 21:28 ` [PATCH net-next v3 3/3] strparser: Documentation Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809.161456.360128105313384145.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).