From: David Miller <davem@davemloft.net>
To: makita.toshiaki@lab.ntt.co.jp
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, nikolay@cumulusnetworks.com
Subject: Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device
Date: Tue, 09 Aug 2016 21:51:28 -0700 (PDT) [thread overview]
Message-ID: <20160809.215128.1552128338274030624.davem@davemloft.net> (raw)
In-Reply-To: <1470276679-5533-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Thu, 4 Aug 2016 11:11:19 +0900
> Adding fdb entries pointing to the bridge device uses fdb_insert(),
> which lacks various checks and does not respect added_by_user flag.
>
> As a result, some inconsistent behavior can happen:
> * Adding temporary entries succeeds but results in permanent entries.
> * Same goes for "dynamic" and "use".
> * Changing mac address of the bridge device causes deletion of
> user-added entries.
> * Replacing existing entries looks successful from userspace but actually
> not, regardless of NLM_F_EXCL flag.
>
> Use the same logic as other entries and fix them.
>
> Fixes: 3741873b4f73 ("bridge: allow adding of fdb entries pointing to the bridge device")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Applied, thanks.
prev parent reply other threads:[~2016-08-10 4:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 2:11 [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device Toshiaki Makita
2016-08-04 7:24 ` Roopa Prabhu via Bridge
2016-08-04 8:15 ` Toshiaki Makita
2016-08-04 10:11 ` Toshiaki Makita
2016-08-04 18:27 ` Roopa Prabhu
2016-08-05 22:26 ` Stephen Hemminger
2016-08-07 15:07 ` Toshiaki Makita
2016-08-10 4:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809.215128.1552128338274030624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).