From: "Jörn Engel" <joern@purestorage.com>
To: Ding Tianhong <dingtianhong@huawei.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: Allow tun-interfaces as slaves
Date: Mon, 8 Aug 2016 20:09:56 -0700 [thread overview]
Message-ID: <20160809030956.GL22974@cork> (raw)
In-Reply-To: <57A93D81.4030808@huawei.com>
Hello Tianhong!
On Tue, Aug 09, 2016 at 10:18:41AM +0800, Ding Tianhong wrote:
>
> I don't understand your problem clearly, can you explain more about how the 00503b6f702e break tun-interfaces
> and we will try to fix it.
Here is a trivial testcase:
openvpn --mktun --dev tun0
echo +tun0 > /sys/class/net/bond0/bonding/slaves
Worked fine before your patch, no longer works after your patch. Works
again after my patch.
> and more, dev_set_mac_address will change the salver's mac address, some nic don't support to change the mac address and
> could not work as bond slave, so we need to check the return value, I don't think this patch has any effective improvement.
Using bonding in balance-rr mode, there doesn't seem to be a need to
change the mac address. I suppose you might care in other modes, but I
don't.
Jörn
next prev parent reply other threads:[~2016-08-09 3:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160808211530.GH22974@cork>
2016-08-08 21:21 ` [Regression] Bonding no longer support tun-interfaces Jörn Engel
2016-08-08 21:48 ` [PATCH] bonding: Allow tun-interfaces as slaves Jörn Engel
2016-08-09 2:18 ` Ding Tianhong
2016-08-09 3:09 ` Jörn Engel [this message]
2016-08-09 5:29 ` zhuyj
2016-08-09 13:28 ` Ding Tianhong
2016-08-09 18:08 ` Jörn Engel
2016-08-09 19:06 ` David Miller
2016-08-09 21:10 ` Jörn Engel
2016-08-09 23:51 ` Jay Vosburgh
2016-08-10 1:06 ` Ding Tianhong
2016-08-10 9:27 ` Ding Tianhong
2016-08-10 17:41 ` Jay Vosburgh
2016-08-11 1:20 ` Ding Tianhong
2016-08-10 21:26 ` Jörn Engel
2016-08-10 22:00 ` Jörn Engel
2016-08-11 0:58 ` Jay Vosburgh
2016-08-11 1:37 ` Ding Tianhong
2016-08-11 18:24 ` Jörn Engel
2016-08-29 22:49 ` Jörn Engel
2016-08-30 1:44 ` Ding Tianhong
2016-08-09 5:52 ` Ding Tianhong
2016-08-09 18:21 ` Jay Vosburgh
2016-08-09 18:40 ` Jörn Engel
2016-08-09 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809030956.GL22974@cork \
--to=joern@purestorage.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).