From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] smc: fix boolreturn.cocci warnings Date: Tue, 9 Aug 2016 20:55:59 +0800 Message-ID: <20160809125559.GA8952@lkp-ib03> References: <201608092041.K2P08ijT%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, utz.bacher@de.ibm.com, ubraun@linux.vnet.ibm.com To: Ursula Braun Return-path: Received: from mga01.intel.com ([192.55.52.88]:46350 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932240AbcHIM5F (ORCPT ); Tue, 9 Aug 2016 08:57:05 -0400 Content-Disposition: inline In-Reply-To: <1470737580-43012-15-git-send-email-ubraun@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: net/smc/smc_wr.c:274:10-11: WARNING: return of 0/1 in function 'smc_wr_tx_has_pending' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Ursula Braun Signed-off-by: Fengguang Wu --- smc_wr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/smc/smc_wr.c +++ b/net/smc/smc_wr.c @@ -271,9 +271,9 @@ bool smc_wr_tx_has_pending(struct smc_li continue; tx_pend = &link->wr_tx_pends[i].priv; if (filter(tx_pend, data)) - return 1; + return true; } - return 0; + return false; } /****************************** receive queue ********************************/