* [PATCH] ravb: use proper names for suspend/resume functions
@ 2016-08-10 11:09 Niklas Söderlund
2016-08-10 11:16 ` Sergei Shtylyov
2016-08-10 21:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Niklas Söderlund @ 2016-08-10 11:09 UTC (permalink / raw)
To: netdev, linux-renesas-soc, sergei.shtylyov
Cc: davem, wsa, Niklas Söderlund
The patch 'ravb: add sleep PM suspend/resume support' used incorrect
function names containing 'runtime' for the suspend and resume
functions.
Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/net/ethernet/renesas/ravb_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 256565e..d4809ad 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2104,7 +2104,7 @@ static int ravb_remove(struct platform_device *pdev)
}
#ifdef CONFIG_PM
-static int ravb_runtime_suspend(struct device *dev)
+static int ravb_suspend(struct device *dev)
{
struct net_device *ndev = dev_get_drvdata(dev);
int ret = 0;
@@ -2117,7 +2117,7 @@ static int ravb_runtime_suspend(struct device *dev)
return ret;
}
-static int ravb_runtime_resume(struct device *dev)
+static int ravb_resume(struct device *dev)
{
struct net_device *ndev = dev_get_drvdata(dev);
struct ravb_private *priv = netdev_priv(ndev);
@@ -2165,7 +2165,7 @@ static int ravb_runtime_nop(struct device *dev)
}
static const struct dev_pm_ops ravb_dev_pm_ops = {
- SET_SYSTEM_SLEEP_PM_OPS(ravb_runtime_suspend, ravb_runtime_resume)
+ SET_SYSTEM_SLEEP_PM_OPS(ravb_suspend, ravb_resume)
SET_RUNTIME_PM_OPS(ravb_runtime_nop, ravb_runtime_nop, NULL)
};
--
2.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ravb: use proper names for suspend/resume functions
2016-08-10 11:09 [PATCH] ravb: use proper names for suspend/resume functions Niklas Söderlund
@ 2016-08-10 11:16 ` Sergei Shtylyov
2016-08-10 21:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-08-10 11:16 UTC (permalink / raw)
To: Niklas Söderlund, netdev, linux-renesas-soc; +Cc: davem, wsa
On 8/10/2016 2:09 PM, Niklas Söderlund wrote:
> The patch 'ravb: add sleep PM suspend/resume support' used incorrect
Actually, that patch should now have immutable SHA1 ID.
> function names containing 'runtime' for the suspend and resume
> functions.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ravb: use proper names for suspend/resume functions
2016-08-10 11:09 [PATCH] ravb: use proper names for suspend/resume functions Niklas Söderlund
2016-08-10 11:16 ` Sergei Shtylyov
@ 2016-08-10 21:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-08-10 21:52 UTC (permalink / raw)
To: niklas.soderlund+renesas; +Cc: netdev, linux-renesas-soc, sergei.shtylyov, wsa
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Date: Wed, 10 Aug 2016 13:09:49 +0200
> The patch 'ravb: add sleep PM suspend/resume support' used incorrect
> function names containing 'runtime' for the suspend and resume
> functions.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-10 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-10 11:09 [PATCH] ravb: use proper names for suspend/resume functions Niklas Söderlund
2016-08-10 11:16 ` Sergei Shtylyov
2016-08-10 21:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).