From: David Miller <davem@davemloft.net>
To: martynas@weave.works
Cc: pshelar@nicira.com, netdev@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH] openvswitch: do not ignore netdev errors when creating tunnel vports
Date: Wed, 10 Aug 2016 23:14:04 -0700 (PDT) [thread overview]
Message-ID: <20160810.231404.72331184301113017.davem@davemloft.net> (raw)
In-Reply-To: <20160809152450.6626-1-martynas@weave.works>
From: Martynas Pumputis <martynas@weave.works>
Date: Tue, 9 Aug 2016 16:24:50 +0100
> The creation of a tunnel vport (geneve, gre, vxlan) brings up a
> corresponding netdev, a multi-step operation which can fail.
>
> For example, changing a vxlan vport's netdev state to 'up' binds the
> vport's socket to a UDP port - if the binding fails (e.g. due to the
> port being in use), the error is currently ignored giving the
> appearance that the tunnel vport creation completed successfully.
>
> Signed-off-by: Martynas Pumputis <martynas@weave.works>
Applied.
prev parent reply other threads:[~2016-08-11 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 15:24 [PATCH] openvswitch: do not ignore netdev errors when creating tunnel vports Martynas Pumputis
[not found] ` <20160809152450.6626-1-martynas-1SEAoVOfG6VEzL6FDj/jAg@public.gmane.org>
2016-08-10 17:26 ` pravin shelar
2016-08-11 6:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810.231404.72331184301113017.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=martynas@weave.works \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).