From: David Miller <davem@davemloft.net>
To: vkuznets@redhat.com
Cc: netdev@vger.kernel.org, haiyangz@microsoft.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH net 2/4] hv_netvsc: reset vf_inject on VF removal
Date: Fri, 12 Aug 2016 20:40:48 -0700 (PDT) [thread overview]
Message-ID: <20160812.204048.1773150628029363073.davem@davemloft.net> (raw)
In-Reply-To: <1470913137-29167-3-git-send-email-vkuznets@redhat.com>
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Thu, 11 Aug 2016 12:58:55 +0200
> We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on
> VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while
> vf_netdev is already NULL and we're trying to inject packets into NULL
> net device in netvsc_recv_callback() causing kernel to crash.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
You can't create a blocking operation problem knowingly in this
patch just because you fix it in patch #4.
You must order your patches such that the driver does not regress
at any intermediate stage of your patch series.
next prev parent reply other threads:[~2016-08-13 3:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 10:58 [PATCH net 0/4] hv_netvsc: fixes for VF removal path Vitaly Kuznetsov
2016-08-11 10:58 ` [PATCH net 1/4] hv_netvsc: don't lose VF information Vitaly Kuznetsov
2016-08-11 15:38 ` Haiyang Zhang
2016-08-11 10:58 ` [PATCH net 2/4] hv_netvsc: reset vf_inject on VF removal Vitaly Kuznetsov
2016-08-11 11:46 ` Yuval Mintz
2016-08-11 12:09 ` Vitaly Kuznetsov
2016-08-12 14:47 ` Stephen Hemminger
2016-08-11 15:38 ` Haiyang Zhang
2016-08-13 3:40 ` David Miller [this message]
2016-08-13 18:35 ` [RFC 1/2] netvsc: reference counting fix Stephen Hemminger
2016-08-13 18:38 ` [RFC 2/2] netvsc: use RCU for VF net device reference Stephen Hemminger
2016-08-15 10:06 ` Vitaly Kuznetsov
2016-08-15 4:31 ` [RFC 1/2] netvsc: reference counting fix David Miller
2016-08-11 10:58 ` [PATCH net 3/4] hv_netvsc: protect module refcount by checking net_device_ctx->vf_netdev Vitaly Kuznetsov
2016-08-11 15:38 ` Haiyang Zhang
2016-08-11 10:58 ` [PATCH net 4/4] hv_netvsc: avoid deadlocks between rtnl lock and netvsc_inject_disable() Vitaly Kuznetsov
2016-08-11 15:38 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812.204048.1773150628029363073.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).