From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: wenxu <wenxu@ucloud.cn>
Cc: David Miller <davem@davemloft.net>,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, kaber@trash.net,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
wenx05124561@163.com, hannes@stressinduktion.org
Subject: Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for gre tunneled skbs
Date: Fri, 12 Aug 2016 08:18:00 +0300 [thread overview]
Message-ID: <20160812081800.02a98e17@halley> (raw)
In-Reply-To: <80d116d7-e61c-1bbd-64bf-e3b1f809419b@ucloud.cn>
Hi,
On Fri, 12 Aug 2016 11:51:07 +0800 wenxu <wenxu@ucloud.cn> wrote:
>
> And in b8247f095edd, the condition skb_iif also should be removed.
> given:
> ovs-internal-dev bridge with ovs-gre
>
> There are the same problem which the skb from local.
There's no need to remove the skb_iif criteria:
For the local bridge port, we have control over its mtu. This allows
setting an mtu value that takes into account the gre encapsulation
performed by other member ports.
By doing so, locally generated traffic (on br0) will have a proper
gso_size.
OTOH if packet arrives from an ingress member port (such as tap0) the
packet's gso_size could have been set by another system - which is not
always under our control.
( see discussion in http://www.spinics.net/lists/netdev/msg385085.html )
Regards,
Shmulik
next prev parent reply other threads:[~2016-08-12 5:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 7:04 [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for gre tunneled skbs wenxu
2016-08-11 0:35 ` David Miller
2016-08-11 19:41 ` Shmulik Ladkani
2016-08-12 4:29 ` wenxu
[not found] ` <80d116d7-e61c-1bbd-64bf-e3b1f809419b@ucloud.cn>
2016-08-12 5:18 ` Shmulik Ladkani [this message]
2016-08-12 11:11 ` Hannes Frederic Sowa
2016-08-15 11:16 ` Shmulik Ladkani
2016-08-16 7:12 ` wenxu
2016-08-19 7:26 ` Shmulik Ladkani
2016-08-19 9:20 ` Hannes Frederic Sowa
2016-08-19 13:40 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812081800.02a98e17@halley \
--to=shmulik.ladkani@gmail.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=wenx05124561@163.com \
--cc=wenxu@ucloud.cn \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).