From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Hadar Hen Zion <hadarh@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Tom Herbert <tom@herbertland.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Amir Vadai <amirv@mellanox.com>
Subject: Re: [PATCH net-next 4/4] net_sched: act_vlan: Add priority option
Date: Fri, 12 Aug 2016 11:18:42 +0300 [thread overview]
Message-ID: <20160812111842.12c38ed3@halley> (raw)
In-Reply-To: <1470835943-9042-5-git-send-email-hadarh@mellanox.com>
Hi,
On Wed, 10 Aug 2016 16:32:23 +0300 Hadar Hen Zion <hadarh@mellanox.com> wrote:
> @@ -181,7 +188,9 @@ static int tcf_vlan_dump(struct sk_buff *skb, struct tc_action *a,
> if (v->tcfv_action == TCA_VLAN_ACT_PUSH &&
> (nla_put_u16(skb, TCA_VLAN_PUSH_VLAN_ID, v->tcfv_push_vid) ||
> nla_put_be16(skb, TCA_VLAN_PUSH_VLAN_PROTOCOL,
> - v->tcfv_push_proto)))
> + v->tcfv_push_proto) ||
> + (v->tcfv_push_prio && nla_put_u8(skb, TCA_VLAN_PUSH_VLAN_PRIORITY,
> + v->tcfv_push_prio))))
> goto nla_put_failure;
nit: We could avoid the 'v->tcfv_push_prio' test, so user can explicitly
observe the associated priority, even if it is set to zero.
Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
prev parent reply other threads:[~2016-08-12 8:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 13:32 [PATCH net-next 0/4] net_sched, flow_dissector, flower: Introduce vlan tag support Hadar Hen Zion
2016-08-10 13:32 ` [PATCH net-next 1/4] flow_dissector: Get vlan info from skb->vlan_tci instead of skb->data Hadar Hen Zion
2016-08-12 6:24 ` Jiri Pirko
2016-08-12 6:36 ` Toshiaki Makita
2016-08-14 14:58 ` Hadar Hen Zion
2016-08-15 2:38 ` Toshiaki Makita
2016-08-15 15:51 ` Hadar Hen Zion
2016-08-15 18:06 ` Jiri Pirko
2016-08-10 13:32 ` [PATCH net-next 2/4] flow_dissector: Get vlan priority in addition to vlan id Hadar Hen Zion
2016-08-10 21:54 ` kbuild test robot
2016-08-10 21:58 ` kbuild test robot
2016-08-11 15:23 ` Hadar Hen Zion
2016-08-12 6:26 ` Jiri Pirko
2016-08-10 13:32 ` [PATCH net-next 3/4] net_sched: flower: Add vlan support Hadar Hen Zion
2016-08-12 5:57 ` Jiri Pirko
2016-08-10 13:32 ` [PATCH net-next 4/4] net_sched: act_vlan: Add priority option Hadar Hen Zion
2016-08-12 6:05 ` Jiri Pirko
2016-08-12 8:18 ` Shmulik Ladkani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812111842.12c38ed3@halley \
--to=shmulik.ladkani@gmail.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).