netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Richard Alpe <richard.alpe@ericsson.com>
Cc: <netdev@vger.kernel.org>, <tipc-discussion@lists.sourceforge.net>
Subject: Re: [PATCH iproute2 2/2] tipc: refactor bearer identification
Date: Fri, 12 Aug 2016 12:54:20 -0700	[thread overview]
Message-ID: <20160812125420.755070d9@xeon-e3> (raw)
In-Reply-To: <1470731670-12723-2-git-send-email-richard.alpe@ericsson.com>

On Tue, 9 Aug 2016 10:34:30 +0200
Richard Alpe <richard.alpe@ericsson.com> wrote:

> Introduce a generic function (nl_add_bearer_name()) that identifies a
> bearer and adds it to an existing netlink message. This reduces code
> complexity and makes the code a little bit easier to maintain.
> 
> Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>

This causes warning on GCC 6 (Debian Testing).

tipc
    CC       bearer.o
bearer.c: In function ‘cmd_bearer_disable’:
bearer.c:325:14: warning: unused variable ‘opt’ [-Wunused-variable]
  struct opt *opt;
              ^
    LINK     tipc


Please fix and resubmit.

      reply	other threads:[~2016-08-12 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09  8:34 [PATCH iproute2 1/2] tipc: fix UDP bearer synopsis Richard Alpe
2016-08-09  8:34 ` [PATCH iproute2 2/2] tipc: refactor bearer identification Richard Alpe
2016-08-12 19:54   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160812125420.755070d9@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=netdev@vger.kernel.org \
    --cc=richard.alpe@ericsson.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).