From: Stephen Hemminger <stephen@networkplumber.org>
To: Tom Herbert <tom@herbertland.com>
Cc: <netdev@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH iproute v3 2/5] ila: Support for configuring ila to use netfilter hook
Date: Fri, 12 Aug 2016 13:01:54 -0700 [thread overview]
Message-ID: <20160812130154.35c7deda@xeon-e3> (raw)
In-Reply-To: <1470778899-2854697-3-git-send-email-tom@herbertland.com>
On Tue, 9 Aug 2016 14:41:36 -0700
Tom Herbert <tom@herbertland.com> wrote:
> Signed-off-by: Tom Herbert <tom@herbertland.com>
> ---
> ip/Makefile | 2 +-
> ip/ip.c | 3 +-
> ip/ip_common.h | 1 +
> ip/ipila.c | 268 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 272 insertions(+), 2 deletions(-)
> create mode 100644 ip/ipila.c
You didn't fix this warning.
ipila.c: In function ‘ila_parse_opt.constprop’:
ipila.c:205:2: warning: ‘locator_match’ may be used uninitialized in this function [-Wmaybe-uninitialized]
addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);
Please send a followup patch for this.
next prev parent reply other threads:[~2016-08-12 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 21:41 [PATCH iproute v3 0/5] iproute: ila and fou additions Tom Herbert
2016-08-09 21:41 ` [PATCH iproute v3 1/5] ila: Support for checksum neutral translation Tom Herbert
2016-08-09 21:41 ` [PATCH iproute v3 2/5] ila: Support for configuring ila to use netfilter hook Tom Herbert
2016-08-12 20:01 ` Stephen Hemminger [this message]
2016-08-09 21:41 ` [PATCH iproute v3 3/5] ip6tnl: Support for fou encapsulation Tom Herbert
2016-08-09 21:41 ` [PATCH iproute v3 4/5] gre6: " Tom Herbert
2016-08-09 21:41 ` [PATCH iproute v3 5/5] fou: Allowing configuring IPv6 listener Tom Herbert
2016-08-12 19:55 ` [PATCH iproute v3 0/5] iproute: ila and fou additions Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812130154.35c7deda@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).