From: Tejun Heo <tj@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Sargun Dhillon <sargun@sargun.me>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] bpf: Add bpf_current_task_under_cgroup helper
Date: Fri, 12 Aug 2016 09:29:35 -0400 [thread overview]
Message-ID: <20160812132935.GL2695@mtj.duckdns.org> (raw)
In-Reply-To: <57AD7D77.4090205@iogearbox.net>
Hello,
On Fri, Aug 12, 2016 at 09:40:39AM +0200, Daniel Borkmann wrote:
> > I actually wish we could rename skb_in_cgroup to skb_under_cgroup. If we ever
> > introduced a check for absolute membership versus ancestral membership, what
> > would we call that?
>
> That option is, by the way, still on the table for -net tree, since 4.8 is not
> released yet, so it could still be renamed into BPF_FUNC_skb_under_cgroup.
>
> Then you could make this one here for -net-next as "BPF_FUNC_current_under_cgroup".
>
> Tejun, Alexei?
lol I should have read the whole thread before replying twice. Sorry
about that. Yeah, if we can still rename it, let's do "under". It's
more intuitive and gives us the room to implement the real "in" test
if ever necessary in the future.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-08-12 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 3:14 [PATCH net-next v4 2/3] bpf: Add bpf_current_task_under_cgroup helper Sargun Dhillon
2016-08-12 4:48 ` Alexei Starovoitov
2016-08-12 4:50 ` Sargun Dhillon
2016-08-12 7:16 ` Daniel Borkmann
2016-08-12 7:22 ` Sargun Dhillon
2016-08-12 7:40 ` Daniel Borkmann
2016-08-12 13:29 ` Tejun Heo [this message]
2016-08-12 15:21 ` Alexei Starovoitov
2016-08-12 15:28 ` Tejun Heo
2016-08-12 13:21 ` Tejun Heo
2016-08-12 13:23 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812132935.GL2695@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).