From: Tejun Heo <tj@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Sargun Dhillon <sargun@sargun.me>,
netdev <netdev@vger.kernel.org>, Martin KaFai Lau <kafai@fb.com>
Subject: Re: [PATCH net-next v4 2/3] bpf: Add bpf_current_task_under_cgroup helper
Date: Fri, 12 Aug 2016 11:28:41 -0400 [thread overview]
Message-ID: <20160812152841.GP2695@mtj.duckdns.org> (raw)
In-Reply-To: <20160812152120.GA41700@ast-mbp.thefacebook.com>
Hello, Alexei.
On Fri, Aug 12, 2016 at 08:21:21AM -0700, Alexei Starovoitov wrote:
> > lol I should have read the whole thread before replying twice. Sorry
> > about that. Yeah, if we can still rename it, let's do "under". It's
> > more intuitive and gives us the room to implement the real "in" test
> > if ever necessary in the future.
>
> agree. Thanks for explaining 'in' vs 'under' terminology.
> since we can still rename skb_in_cgroup we should do it.
Sounds good to me.
> and since that was my only nit for this patch.
> Acked-by: Alexei Starovoitov <ast@kernel.org>
FWIW,
Acked-by: Tejun Heo <tj@kernel.org>
> All 3 patches should go via net-next and to avoid conflicts 1/3 can be
> in cgroup tree as well (if you think there will be conflicts).
> We did that in the past with tip and net-next and it worked out well.
Yeah, just route it through net-next. If other changes ever need it,
I'll include the commit in cgroup tree.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-08-12 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 3:14 [PATCH net-next v4 2/3] bpf: Add bpf_current_task_under_cgroup helper Sargun Dhillon
2016-08-12 4:48 ` Alexei Starovoitov
2016-08-12 4:50 ` Sargun Dhillon
2016-08-12 7:16 ` Daniel Borkmann
2016-08-12 7:22 ` Sargun Dhillon
2016-08-12 7:40 ` Daniel Borkmann
2016-08-12 13:29 ` Tejun Heo
2016-08-12 15:21 ` Alexei Starovoitov
2016-08-12 15:28 ` Tejun Heo [this message]
2016-08-12 13:21 ` Tejun Heo
2016-08-12 13:23 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812152841.GP2695@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).