From: Phil Sutter <phil@nwl.cc>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, stephen@networkplumber.org
Subject: Re: [PATCH iproute2] ip route: restore_handler should check tb[RTA_PREFSRC] for local networks
Date: Fri, 12 Aug 2016 17:43:45 +0200 [thread overview]
Message-ID: <20160812154345.GL10197@orbyte.nwl.cc> (raw)
In-Reply-To: <f805ffe5dad63ae04330df32bbe6cf532a6772b7.1470561150.git.lucien.xin@gmail.com>
On Sun, Aug 07, 2016 at 05:12:30PM +0800, Xin Long wrote:
> Prior to this patch, If one route entry's RTA_PREFSRC and RTA_GATEWAY
> both were NULL, it was supposed to be restored ONLY as a local address.
>
> But as it didn't check tb[RTA_PREFSRC] when restoring local networks,
> rtattr_cmp would return a success if it was NULL, this route entry would
> be restored again as a local network.
>
> This patch is to add tb[RTA_PREFSRC] check when restoring local networks.
>
> Fixes: 74af8dd9620e ("ip route: restore route entries in correct order")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Tested-by: Phil Sutter <phil@nwl.cc>
next prev parent reply other threads:[~2016-08-12 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 9:12 [PATCH iproute2] ip route: restore_handler should check tb[RTA_PREFSRC] for local networks Xin Long
2016-08-12 15:43 ` Phil Sutter [this message]
2016-08-17 3:32 ` Xin Long
2016-08-17 20:54 ` Stephen Hemminger
2016-08-18 21:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812154345.GL10197@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).