Re: [PATCH net] bpf: fix bpf_skb_in_cgroup helper naming

David Miller
2016-08-13T05:02:45Z

From: Daniel Borkmann <daniel@iogearbox.net>
Date: Fri, 12 Aug 2016 22:17:17 +0200

> While hashing out BPF's current_task_under_cgroup helper bits, it came
> to discussion that the skb_in_cgroup helper name was suboptimally chosen.
>
> Tejun says:
>
> So, I think in_cgroup should mean that the object is in that
> particular cgroup while under_cgroup in the subhierarchy of that
> cgroup. Let's rename the other subhierarchy test to under too. I
> think that'd be a lot less confusing going forward.
>
> [...]
>
> It's more intuitive and gives us the room to implement the real
> "in" test if ever necessary in the future.
>
> Since this touches uapi bits, we need to change this as long as v4.8
> is not yet officially released. Thus, change the helper enum and rename
> related bits.
>
> Fixes: 4a482f34afcc ("cgroup: bpf: Add bpf_skb_in_cgroup_proto")
> Reference: http://patchwork.ozlabs.org/patch/658500/
> Suggested-by: Sargun Dhillon <sargun@sargun.me>
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Applied.