From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: netdev@vger.kernel.org, hannes@stressinduktion.org,
ek@google.com, hideaki.yoshifuji@miraclelinux.com,
dsa@cumulusnetworks.com
Subject: Re: [PATCH net v2] net: ipv6: Fix ping to link-local addresses.
Date: Mon, 15 Aug 2016 10:55:22 -0700 (PDT) [thread overview]
Message-ID: <20160815.105522.1444417738258658028.davem@davemloft.net> (raw)
In-Reply-To: <1471018418-12212-1-git-send-email-lorenzo@google.com>
From: Lorenzo Colitti <lorenzo@google.com>
Date: Sat, 13 Aug 2016 01:13:38 +0900
> ping_v6_sendmsg does not set flowi6_oif in response to
> sin6_scope_id or sk_bound_dev_if, so it is not possible to use
> these APIs to ping an IPv6 address on a different interface.
> Instead, it sets flowi6_iif, which is incorrect but harmless.
>
> Stop setting flowi6_iif, and support various ways of setting oif
> in the same priority order used by udpv6_sendmsg.
>
> Tested: https://android-review.googlesource.com/#/c/254470/
> Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
I'm expecting a new version of this patch with changes handling
the situation that VRF needs.
Just FYI...
next prev parent reply other threads:[~2016-08-15 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 16:13 [PATCH net v2] net: ipv6: Fix ping to link-local addresses Lorenzo Colitti
2016-08-15 17:55 ` David Miller [this message]
2016-08-15 18:44 ` David Ahern
2016-08-15 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815.105522.1444417738258658028.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=ek@google.com \
--cc=hannes@stressinduktion.org \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).