* [PATCH -next] net: thunderx: Remove unnecessary pci_set_drvdata()
@ 2016-08-15 22:51 Wei Yongjun
2016-08-15 23:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-15 22:51 UTC (permalink / raw)
To: Sunil Goutham, Robert Richter; +Cc: Wei Yongjun, linux-arm-kernel, netdev
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/net/ethernet/cavium/thunder/thunder_xcv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
index 9210d04..67befed 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
@@ -194,7 +194,6 @@ err_release_regions:
err_disable_device:
pci_disable_device(pdev);
err_kfree:
- pci_set_drvdata(pdev, NULL);
devm_kfree(dev, xcv);
xcv = NULL;
return err;
@@ -211,7 +210,6 @@ static void xcv_remove(struct pci_dev *pdev)
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static struct pci_driver xcv_driver = {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: thunderx: Remove unnecessary pci_set_drvdata()
2016-08-15 22:51 [PATCH -next] net: thunderx: Remove unnecessary pci_set_drvdata() Wei Yongjun
@ 2016-08-15 23:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-15 23:35 UTC (permalink / raw)
To: weiyj.lk; +Cc: sgoutham, rric, linux-arm-kernel, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 15 Aug 2016 22:51:29 +0000
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-15 23:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-15 22:51 [PATCH -next] net: thunderx: Remove unnecessary pci_set_drvdata() Wei Yongjun
2016-08-15 23:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).