Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Amir Vadai <amir@vadai.me>, Cong Wang <xiyou.wangcong@gmail.com>,
	John Fastabend <john.fastabend@gmail.com>,
	Jiri Pirko <jiri@mellanox.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Hadar Har-Zion <hadarh@mellanox.com>,
	Oded Shanoon <odeds@mellanox.com>,
	Amir Vadai <amirva@mellanox.com>
Subject: Re: [RFC net-next 0/2] net/sched: cls_flower, act_mirred: VXLAN redirect using TC
Date: Mon, 15 Aug 2016 14:34:00 +0200	[thread overview]
Message-ID: <20160815123400.GH2024@nanopsycho> (raw)
In-Reply-To: <faa0a9ab-fc02-543e-c60a-0d22b253a830@mojatatu.com>

Mon, Aug 15, 2016 at 12:08:10PM CEST, jhs@mojatatu.com wrote:
>On 16-08-15 05:08 AM, Amir Vadai wrote:
>> On Mon, Aug 15, 2016 at 11:17:40AM +0300, Amir Vadai wrote:
>> > On Mon, Aug 15, 2016 at 09:11:22AM +0200, Jiri Pirko wrote:
>> > > Sun, Aug 14, 2016 at 07:53:30PM CEST, xiyou.wangcong@gmail.com wrote:
>
>> > 
>> > Thanks,
>> > Amir
>> 
>> Any objection to the following?
>> 
>> # ENCAP rule
>> tc filter add dev $ETH protocol ip parent ffff: prio 10 \
>> 		flower ip_proto 1 \
>> 		action set_tunnel_key src_ip 11.11.0.1 dst_ip 11.11.0.2 key_id 11 dst_port 4789 \
>> 		action mirred egress redirect dev $VXLAN
>
>Assuming $VXLAN is actually not a linux netdev of type vxlan?
>then the action does vxlan encap redirect sends it to the $VXLAN
>dev with encapsulation in place.
>Sounds to me like a name like "vxlan" would be more usable. Example:

I believe those are generic tunelling data


>
>tc filter add dev $ETH protocol ip parent ffff: prio 10 ..
>action vxlan encap src_ip 11.11.0.1 dst_ip 11.11.0.2 key_id 11 ....
>action mirred egress redirect dev eth0
>
>> 
>> # DECAP rule
>> tc filter add dev $VXLAN protocol ip parent ffff: prio 10 \
>> 		flower \
>> 			enc_src_ip 11.11.0.2 enc_dst_ip 11.11.0.1 enc_key_id 11 \
>> 			ip_proto 1 \
>> 		action mirred egress redirect dev $ETH
>> 
>
>And a decap would be of the form:
>tc filter add dev $ETH protocol ip parent ffff: prio 10 ..
>action vxlan decap

That's right. Amir, don't you need decap here to drop the tunnel
metadata?


>
>i.e there is no redirect needed here, no?
>
>cheers,
>jamal

  parent reply	other threads:[~2016-08-15 12:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-14 14:06 [RFC net-next 0/2] net/sched: cls_flower, act_mirred: VXLAN redirect using TC Amir Vadai
2016-08-14 14:06 ` [RFC net-next 1/2] net/sched: cls_flower: Introduce classify by vxlan outer headers Amir Vadai
2016-08-14 14:06 ` [RFC net-next 2/2] net/sched: act_mirred: Introduce vxlan support Amir Vadai
2016-08-14 17:53 ` [RFC net-next 0/2] net/sched: cls_flower, act_mirred: VXLAN redirect using TC Cong Wang
2016-08-15  5:05   ` John Fastabend
2016-08-15  7:11   ` Jiri Pirko
2016-08-15  8:17     ` Amir Vadai
2016-08-15  9:08       ` Amir Vadai
2016-08-15  9:48         ` Jiri Pirko
2016-08-15  9:50         ` Shmulik Ladkani
2016-08-15  9:58           ` Amir Vadai
2016-08-15 10:42             ` Shmulik Ladkani
2016-08-15 10:08         ` Jamal Hadi Salim
2016-08-15 10:24           ` Shmulik Ladkani
2016-08-15 10:41             ` Jamal Hadi Salim
2016-08-15 11:36               ` Amir Vadai
2016-08-15 16:35                 ` John Fastabend
2016-08-15 12:34           ` Jiri Pirko [this message]
2016-08-15 12:59             ` Amir Vadai
2016-08-15 16:37               ` John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160815123400.GH2024@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=amir@vadai.me \
    --cc=amirva@mellanox.com \
    --cc=hadarh@mellanox.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@mellanox.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=odeds@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox