netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Nagaraju Lakkaraju <Raju.Lakkaraju@microsemi.com>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Allan Nielsen <Allan.Nielsen@microsemi.com>
Subject: Re: Microsemi VSC 8531/41 PHY Driver
Date: Tue, 16 Aug 2016 21:48:03 +0200	[thread overview]
Message-ID: <20160816194803.GA3751@lunn.ch> (raw)
In-Reply-To: <20160805122420.GA3184@microsemi.com>

On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote:
> Hello,
> 
> I added all review comments and re-sending for review.

You should also take a look at the output of scripts/checkpatch.pl:

total: 9 errors, 82 warnings, 1 checks, 179 lines checked

       Andrew

  parent reply	other threads:[~2016-08-16 19:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26  9:49 Microsemi VSC 8531/41 PHY Driver Raju Lakkaraju
2016-07-26 11:55 ` Andrew Lunn
2016-07-26 12:20   ` Raju Lakkaraju
2016-07-26 12:43     ` Andrew Lunn
2016-07-28  6:44       ` Raju Lakkaraju
2016-07-28 17:35         ` Florian Fainelli
2016-08-04  9:31           ` Nagaraju Lakkaraju
2016-07-29  8:04         ` Andrew Lunn
2016-07-29  8:17         ` Andrew Lunn
2016-08-04  9:17           ` Nagaraju Lakkaraju
2016-08-05 12:24           ` Nagaraju Lakkaraju
2016-08-16 19:41             ` Andrew Lunn
2016-08-16 19:48             ` Andrew Lunn [this message]
2016-09-08  8:39               ` [PATCH net-next 1/1] net: phy: Fixed checkpatch errors for Microsemi PHYs Raju Lakkaraju
2016-09-10  1:16                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160816194803.GA3751@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Allan.Nielsen@microsemi.com \
    --cc=Raju.Lakkaraju@microsemi.com \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).