From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing
Date: Wed, 17 Aug 2016 23:27:20 +0200 [thread overview]
Message-ID: <20160817212720.GE28702@orbyte.nwl.cc> (raw)
In-Reply-To: <1464811430-19415-2-git-send-email-phil@nwl.cc>
On Wed, Jun 01, 2016 at 10:03:49PM +0200, Phil Sutter wrote:
> Not sure whether I misinterpret commit 7b8179c780a1a, but it looks
> overly complicated. Instead rely upon parse_rtattr_nested() to assign
> the relevant pointer if requested rtattr fields are present.
In order to validate correctness of this patch, I compiled a kernel
which does not export IFLA_VF_SPOOFCHK and verified correct
functionality.
Is there anything else I could do in order to convince you to accept
these patches?
Thanks, Phil
next prev parent reply other threads:[~2016-08-17 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 20:03 [iproute PATCH 0/2] Minor vf_info review Phil Sutter
2016-06-01 20:03 ` [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing Phil Sutter
2016-06-01 22:00 ` Greg Rose
2016-06-01 22:07 ` Phil Sutter
2016-06-01 22:36 ` Greg Rose
2016-07-01 17:50 ` Phil Sutter
2016-07-20 20:10 ` Phil Sutter
2016-08-17 21:27 ` Phil Sutter [this message]
2016-06-01 20:03 ` [iproute PATCH 2/2] ipaddress: Print IFLA_VF_QUERY_RSS_EN setting Phil Sutter
-- strict thread matches above, loose matches on Subject: below --
2016-11-08 21:29 [iproute PATCH 0/2] Resend: Simplify and enhance vf_info parsing Phil Sutter
2016-11-08 21:29 ` [iproute PATCH 1/2] ipaddress: Simplify " Phil Sutter
2016-11-08 23:05 ` Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817212720.GE28702@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).