From: David Miller <davem@davemloft.net>
To: fgao@ikuai8.com
Cc: xeb@mail.ru, philipp@redfish-solutions.com,
netdev@vger.kernel.org, gfree.wind@gmail.com
Subject: Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number
Date: Fri, 19 Aug 2016 14:31:28 -0700 (PDT) [thread overview]
Message-ID: <20160819.143128.561754527412577407.davem@davemloft.net> (raw)
In-Reply-To: <1471495654-20134-1-git-send-email-fgao@ikuai8.com>
From: fgao@ikuai8.com
Date: Thu, 18 Aug 2016 12:47:34 +0800
> @@ -54,6 +54,8 @@ static struct proto pptp_sk_proto __read_mostly;
> static const struct ppp_channel_ops pptp_chan_ops;
> static const struct proto_ops pptp_ops;
>
> +static const u8 fixed_ppphdr[2] = {PPP_ALLSTATIONS, PPP_UI};
> +
This makes things much worse in my opinion, and at the cost
of two extra bytes in the data section as well.
I'm not applying this.
next prev parent reply other threads:[~2016-08-19 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 4:47 [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number fgao
2016-08-19 21:31 ` David Miller [this message]
2016-08-19 23:14 ` Philp Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819.143128.561754527412577407.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=philipp@redfish-solutions.com \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).