From: Andrew Lunn <andrew@lunn.ch>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: Zefir Kurtisi <zefir.kurtisi@neratec.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"claudiu.manoil@freescale.com" <claudiu.manoil@freescale.com>
Subject: Re: [PATCH] gianfar: prevent fragmentation in DSA environments
Date: Fri, 19 Aug 2016 18:39:44 +0200 [thread overview]
Message-ID: <20160819163944.GF22939@lunn.ch> (raw)
In-Reply-To: <AM5PR0401MB2561CB4CA30BC13EBFFAD43796160@AM5PR0401MB2561.eurprd04.prod.outlook.com>
> >> -#define GFAR_RXB_SIZE 1536
> >> +/* prevent fragmenation by HW in DSA environments */
> >> +#define GFAR_RXB_SIZE (1536 + RXBUF_ALIGNMENT)
> >
> >Hi Zefir
> >
> >Using RXBUF_ALIGNMENT suggests this has something to do with
> >alignment, not extra headers.
> >
> >How about
> >
> >/* Prevent fragmenation by HW when using extra headers like DSA */
> >#define GFAR_RXB_SIZE (1536 + 8)
> >
>
> MRBL (Maximum receive buffer length) must be multiple of 64.
> Please consult de hardware documentation at least before prosing
> changes to the driver.
Hi Claudiu
Thanks for pointing this out. This makes RXBUF_ALIGNMENT even worse
for understabability, since you say multiples of 64 is important, not
alignment.
How about
/* Prevent fragmentation by HW when using extra headers like DSA,
while respecting the multiple of 64 requirement. */
#define GFAR_RXB_SIZE roundup(1536 + 8, 64)
Andrew
next prev parent reply other threads:[~2016-08-19 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 9:16 [PATCH] gianfar: prevent fragmentation in DSA environments Zefir Kurtisi
2016-08-19 14:59 ` Andrew Lunn
2016-08-19 15:49 ` Claudiu Manoil
2016-08-19 16:39 ` Andrew Lunn [this message]
2016-08-19 21:24 ` Claudiu Manoil
2016-08-19 21:45 ` Andrew Lunn
2016-08-22 13:44 ` Zefir Kurtisi
2016-08-19 16:43 ` Zefir Kurtisi
2016-08-19 17:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819163944.GF22939@lunn.ch \
--to=andrew@lunn.ch \
--cc=claudiu.manoil@freescale.com \
--cc=claudiu.manoil@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).