From: Andrew Lunn <andrew@lunn.ch>
To: Zefir Kurtisi <zefir.kurtisi@neratec.com>
Cc: netdev@vger.kernel.org, claudiu.manoil@freescale.com
Subject: Re: [PATCH] gianfar: prevent fragmentation in DSA environments
Date: Fri, 19 Aug 2016 19:05:03 +0200 [thread overview]
Message-ID: <20160819170503.GA14068@lunn.ch> (raw)
In-Reply-To: <c1cda2ea-21e8-0265-e1c3-687f2396a7f1@neratec.com>
> I don't fully understand why GFAR_RXB_SIZE has to be lower than
> that, preventing the HW using all available memory - the freescale
> guys most probably do.
That will be because the cache invalidates in the DMA API are
expensive. There is no point invalidating the whole 2K if you never
make use of the top part. Just invalidate what is actually used. I
optimised the Intel i210 driver recently along these lines, and my
receive performance went up 6%
Andrew
prev parent reply other threads:[~2016-08-19 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 9:16 [PATCH] gianfar: prevent fragmentation in DSA environments Zefir Kurtisi
2016-08-19 14:59 ` Andrew Lunn
2016-08-19 15:49 ` Claudiu Manoil
2016-08-19 16:39 ` Andrew Lunn
2016-08-19 21:24 ` Claudiu Manoil
2016-08-19 21:45 ` Andrew Lunn
2016-08-22 13:44 ` Zefir Kurtisi
2016-08-19 16:43 ` Zefir Kurtisi
2016-08-19 17:05 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819170503.GA14068@lunn.ch \
--to=andrew@lunn.ch \
--cc=claudiu.manoil@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).