From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: David Miller <davem@davemloft.net>,
Jamie Lentin <jm@lentin.co.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/4] dsa: mv88e6xxx: Delete ppu timer when removing module
Date: Mon, 22 Aug 2016 17:07:45 +0200 [thread overview]
Message-ID: <20160822150745.GC16229@lunn.ch> (raw)
In-Reply-To: <87zio47t7s.fsf@ketchup.mtl.sfl>
On Mon, Aug 22, 2016 at 10:51:03AM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn <andrew@lunn.ch> writes:
>
> > The PPU method of accessing PHYs makes use of a timer. Make sure this
> > timer is deleted before unloading the driver.
> >
> > Reported-by: Jamie Lentin <jm@lentin.co.uk>
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> I'm wondering if the PPU shouldn't be disabled before unloading the
> module...
Humm, i did not thing about that.
Actually, we have a general issue here. On unload, we leave the switch
'running'. The SF2 driver disables all the ports. The b53 seems to
leave the switch running.
We should define a general policy about this, and implement it in all
drivers. As such, your comment is valid, but a different patch set.
Andrew
next prev parent reply other threads:[~2016-08-22 15:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 14:01 [PATCH 0/4] Fix MV88E6131 tagging Andrew Lunn
2016-08-22 14:01 ` [PATCH 1/4] net: dsa: Allow the DSA driver to indicate the tag protocol Andrew Lunn
2016-08-22 14:32 ` Vivien Didelot
2016-08-22 14:01 ` [PATCH 2/4] net: dsa: mv88e6xxx: Fix support for DSA tagging for older switches Andrew Lunn
2016-08-22 14:41 ` Vivien Didelot
2016-08-22 14:01 ` [PATCH 3/4] dsa: mv88e6xxx: Delete ppu timer when removing module Andrew Lunn
2016-08-22 14:51 ` Vivien Didelot
2016-08-22 15:07 ` Andrew Lunn [this message]
2016-08-22 15:39 ` Vivien Didelot
2016-08-23 13:37 ` Sergei Shtylyov
2016-08-23 14:10 ` Andrew Lunn
2016-08-22 14:01 ` [PATCH 4/4] net: mv88e6xxx: Enable PORT_CONTROL_FORWARD_UNKNOWN for DSA-tagged CPU ports Andrew Lunn
2016-08-22 15:16 ` Vivien Didelot
2016-08-22 14:36 ` [PATCH 0/4] Fix MV88E6131 tagging Jamie Lentin
2016-08-23 4:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822150745.GC16229@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jm@lentin.co.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).