* [ethtool PATCH v3 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
@ 2016-08-21 23:44 Vidya Sagar Ravipati
2016-08-22 19:27 ` John W. Linville
0 siblings, 1 reply; 2+ messages in thread
From: Vidya Sagar Ravipati @ 2016-08-21 23:44 UTC (permalink / raw)
To: linville, netdev, davem, decot
Cc: bkenward, daniel, galp, roopa, gospo, dustin, ben
From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
Enhancing link mode bits to support 25G/50G/100G
for supported and advertised speed mode bits
Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
Acked-By: David Decotigny <decot@googlers.com>
---
ethtool.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 1d6564e..5c3c765 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -512,6 +512,15 @@ static void init_global_link_mode_masks(void)
ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT,
ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT,
ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
+ ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
+ ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
};
static const enum ethtool_link_mode_bit_indices
additional_advertised_flags_bits[] = {
@@ -632,6 +641,24 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
"56000baseSR4/Full" },
{ 0, ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
"56000baseLR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
+ "25000baseCR/Full" },
+ { 0, ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
+ "25000baseKR/Full" },
+ { 0, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
+ "25000baseSR/Full" },
+ { 0, ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
+ "50000baseCR2/Full" },
+ { 0, ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
+ "50000baseKR2/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
+ "100000baseKR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
+ "100000baseSR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
+ "100000baseCR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
+ "100000baseLR4_ER4/Full" },
};
int indent;
int did1, new_line_pend, i;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ethtool PATCH v3 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
2016-08-21 23:44 [ethtool PATCH v3 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G Vidya Sagar Ravipati
@ 2016-08-22 19:27 ` John W. Linville
0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2016-08-22 19:27 UTC (permalink / raw)
To: Vidya Sagar Ravipati
Cc: netdev, davem, decot, bkenward, daniel, galp, roopa, gospo,
dustin, ben
On Sun, Aug 21, 2016 at 04:44:04PM -0700, Vidya Sagar Ravipati wrote:
> From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
>
> Enhancing link mode bits to support 25G/50G/100G
> for supported and advertised speed mode bits
>
> Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
> Acked-By: David Decotigny <decot@googlers.com>
> ---
> ethtool.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/ethtool.c b/ethtool.c
> index 1d6564e..5c3c765 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -512,6 +512,15 @@ static void init_global_link_mode_masks(void)
> ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT,
> ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT,
> ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
> + ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
> + ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
> + ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
> + ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
> + ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
> };
> static const enum ethtool_link_mode_bit_indices
> additional_advertised_flags_bits[] = {
> @@ -632,6 +641,24 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
> "56000baseSR4/Full" },
> { 0, ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
> "56000baseLR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
> + "25000baseCR/Full" },
> + { 0, ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
> + "25000baseKR/Full" },
> + { 0, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
> + "25000baseSR/Full" },
> + { 0, ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
> + "50000baseCR2/Full" },
> + { 0, ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
> + "50000baseKR2/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
> + "100000baseKR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
> + "100000baseSR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
> + "100000baseCR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
> + "100000baseLR4_ER4/Full" },
> };
> int indent;
> int did1, new_line_pend, i;
If my other comment wasn't clear, this is the patch I
to which I was suggesting that you could add support for
ETHTOOL_LINK_MODE_50000baseSR2_Full_BIT.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-22 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-21 23:44 [ethtool PATCH v3 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G Vidya Sagar Ravipati
2016-08-22 19:27 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).