From: "John W. Linville" <linville@tuxdriver.com>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>
Cc: netdev@vger.kernel.org, vidya@cumulusnetworks.com
Subject: Re: [PATCH ethtool 0/3] ethtool: Add support for new high speed adv.
Date: Mon, 22 Aug 2016 15:32:19 -0400 [thread overview]
Message-ID: <20160822193218.GD2628@tuxdriver.com> (raw)
In-Reply-To: <1471845039-28718-1-git-send-email-Yuval.Mintz@qlogic.com>
On Mon, Aug 22, 2016 at 08:50:36AM +0300, Yuval Mintz wrote:
> This allows ethtool to utilize the link capabilities/adv./lp bitmasks
> to show and set the additional 25g, 50g and 100g link speeds.
>
> Patches #1 & #2 are based on Vidya Sagar Ravipati's patches
> [with the only addition being the addition of the 50g SR2 mode],
> while patch #3 updates the man-page with the additional modes.
>
> Can't claim to have tried all modes, although I did play with both
> 25g KR and 50g KR2 which seemed to be working fine.
>
> Yuval Mintz (3):
> ethtool: Copy high-speed bits from ethtool.h
> ethtool: Add support 25g, 50g and 100g speeds
> ethtool: Document new ethtool advertise speeds
>
> ethtool-copy.h | 12 +++++++++++-
> ethtool.8.in | 10 ++++++++++
> ethtool.c | 30 ++++++++++++++++++++++++++++++
> 3 files changed, 51 insertions(+), 1 deletion(-)
It looks like Vidya wasn't completely in-sync with you on this! But,
I like that you included the later bits for ethtool-copy.h and that
you added man page updates.
Could you and Vidya get together and post a unified patchset,
please? Or if Vidya posts the updates I requested, I can simply take
your (i.e. Yuval's) patch 3/3 on top of that.
John
--
John W. Linville Someday the world will need a hero, yand you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2016-08-22 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 5:50 [PATCH ethtool 0/3] ethtool: Add support for new high speed adv Yuval Mintz
2016-08-22 5:50 ` [PATCH ethtool 1/3] ethtool: Copy high-speed bits from ethtool.h Yuval Mintz
2016-08-22 5:50 ` [PATCH ethtool 2/3] ethtool: Add support for 25g, 50g and 100g advertise Yuval Mintz
2016-08-22 5:50 ` [PATCH ethtool 3/3] ethtool: Document new ethtool advertise speeds Yuval Mintz
2016-08-22 19:32 ` John W. Linville [this message]
2016-08-23 3:44 ` [PATCH ethtool 0/3] ethtool: Add support for new high speed adv Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822193218.GD2628@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=vidya@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).