* [PATCH V2] liquidio: declare liquidio_set_rxcsum_command static
@ 2016-08-22 15:52 Nicholas Mc Guire
2016-08-23 23:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2016-08-22 15:52 UTC (permalink / raw)
To: Derek Chickles
Cc: Satanand Burla, Felix Manlunas, Raghu Vatsavayi, netdev,
linux-kernel, Nicholas Mc Guire
liquidio_set_rxcsum_command is a local function only, no need to expose
it outside of lio_main.c so declare it static and make sparse happy.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
V2: forgot to fix up the checkpatch.pl warnings...
Detected by sparse:
CHECK drivers/net/ethernet/cavium/liquidio/lio_main.c
drivers/net/ethernet/cavium/liquidio/lio_main.c:3193:5: warning: symbol
'liquidio_set_rxcsum_command' was not declared. Should it be static?
Patch was compile tested with: x86_64_defconfig + CONFIG_LIQUIDIO=m
Patch is against 4.8.0-rc2 (localversion-next is -next-20160822)
drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index 20d6942..f659a95 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -3190,8 +3190,8 @@ static int liquidio_vlan_rx_kill_vid(struct net_device *netdev,
* OCTNET_CMD_RXCSUM_DISABLE
* @returns SUCCESS or FAILURE
*/
-int liquidio_set_rxcsum_command(struct net_device *netdev, int command,
- u8 rx_cmd)
+static int liquidio_set_rxcsum_command(struct net_device *netdev, int command,
+ u8 rx_cmd)
{
struct lio *lio = GET_LIO(netdev);
struct octeon_device *oct = lio->oct_dev;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] liquidio: declare liquidio_set_rxcsum_command static
2016-08-22 15:52 [PATCH V2] liquidio: declare liquidio_set_rxcsum_command static Nicholas Mc Guire
@ 2016-08-23 23:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-23 23:54 UTC (permalink / raw)
To: hofrat
Cc: derek.chickles, satananda.burla, felix.manlunas, raghu.vatsavayi,
netdev, linux-kernel
From: Nicholas Mc Guire <hofrat@osadl.org>
Date: Mon, 22 Aug 2016 17:52:00 +0200
> liquidio_set_rxcsum_command is a local function only, no need to expose
> it outside of lio_main.c so declare it static and make sparse happy.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-23 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-22 15:52 [PATCH V2] liquidio: declare liquidio_set_rxcsum_command static Nicholas Mc Guire
2016-08-23 23:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).