* [PATCH -next] xen-netback: using kfree_rcu() to simplify the code
@ 2016-08-22 23:01 Wei Yongjun
2016-08-24 0:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-22 23:01 UTC (permalink / raw)
To: Wei Liu; +Cc: Wei Yongjun, xen-devel, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
The callback function of call_rcu() just calls a kfree(), so we
can use kfree_rcu() instead of call_rcu() + callback function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/xen-netback/hash.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-netback/hash.c
index 282b16d..e8c5ddd 100644
--- a/drivers/net/xen-netback/hash.c
+++ b/drivers/net/xen-netback/hash.c
@@ -32,15 +32,6 @@
#include <linux/vmalloc.h>
#include <linux/rculist.h>
-static void xenvif_del_hash(struct rcu_head *rcu)
-{
- struct xenvif_hash_cache_entry *entry;
-
- entry = container_of(rcu, struct xenvif_hash_cache_entry, rcu);
-
- kfree(entry);
-}
-
static void xenvif_add_hash(struct xenvif *vif, const u8 *tag,
unsigned int len, u32 val)
{
@@ -76,7 +67,7 @@ static void xenvif_add_hash(struct xenvif *vif, const u8 *tag,
if (++vif->hash.cache.count > xenvif_hash_cache_size) {
list_del_rcu(&oldest->link);
vif->hash.cache.count--;
- call_rcu(&oldest->rcu, xenvif_del_hash);
+ kfree_rcu(oldest, rcu);
}
}
@@ -114,7 +105,7 @@ static void xenvif_flush_hash(struct xenvif *vif)
list_for_each_entry_rcu(entry, &vif->hash.cache.list, link) {
list_del_rcu(&entry->link);
vif->hash.cache.count--;
- call_rcu(&entry->rcu, xenvif_del_hash);
+ kfree_rcu(entry, rcu);
}
spin_unlock_irqrestore(&vif->hash.cache.lock, flags);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] xen-netback: using kfree_rcu() to simplify the code
2016-08-22 23:01 [PATCH -next] xen-netback: using kfree_rcu() to simplify the code Wei Yongjun
@ 2016-08-24 0:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-24 0:01 UTC (permalink / raw)
To: weiyj.lk; +Cc: wei.liu2, weiyongjun1, xen-devel, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 22 Aug 2016 23:01:29 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The callback function of call_rcu() just calls a kfree(), so we
> can use kfree_rcu() instead of call_rcu() + callback function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-24 0:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-22 23:01 [PATCH -next] xen-netback: using kfree_rcu() to simplify the code Wei Yongjun
2016-08-24 0:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).