From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net] sctp: fix overrun in sctp_diag_dump_one() Date: Tue, 23 Aug 2016 14:30:49 -0300 Message-ID: <20160823173049.GA11144@localhost.localdomain> References: <1471966852-6218-1-git-send-email-lrichard@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, Xin Long To: Lance Richardson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbcHWRhJ (ORCPT ); Tue, 23 Aug 2016 13:37:09 -0400 Content-Disposition: inline In-Reply-To: <1471966852-6218-1-git-send-email-lrichard@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Aug 23, 2016 at 11:40:52AM -0400, Lance Richardson wrote: > The function sctp_diag_dump_one() currently performs a memcpy() > of 64 bytes from a 16 byte field into another 16 byte field. Fix > by using correct size, use sizeof to obtain correct size instead > of using a hard-coded constant. > > Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file") > Signed-off-by: Lance Richardson Acked-by: Marcelo Ricardo Leitner Dave, please consider it to -stable. Thanks! > --- > net/sctp/sctp_diag.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c > index bb69153..f3508aa 100644 > --- a/net/sctp/sctp_diag.c > +++ b/net/sctp/sctp_diag.c > @@ -424,11 +424,13 @@ static int sctp_diag_dump_one(struct sk_buff *in_skb, > paddr.v4.sin_family = AF_INET; > } else { > laddr.v6.sin6_port = req->id.idiag_sport; > - memcpy(&laddr.v6.sin6_addr, req->id.idiag_src, 64); > + memcpy(&laddr.v6.sin6_addr, req->id.idiag_src, > + sizeof(laddr.v6.sin6_addr)); > laddr.v6.sin6_family = AF_INET6; > > paddr.v6.sin6_port = req->id.idiag_dport; > - memcpy(&paddr.v6.sin6_addr, req->id.idiag_dst, 64); > + memcpy(&paddr.v6.sin6_addr, req->id.idiag_dst, > + sizeof(paddr.v6.sin6_addr)); > paddr.v6.sin6_family = AF_INET6; > } > > -- > 2.5.5 >