From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>,
Julien Goodwin <julieng@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter
Date: Wed, 24 Aug 2016 10:35:20 -0700 [thread overview]
Message-ID: <20160824103520.56fad551@xeon-e3> (raw)
In-Reply-To: <1472054483.14381.86.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, 24 Aug 2016 09:01:23 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Adds SNMP counter for drops caused by MD5 mismatches.
>
> The current syslog might help, but a counter is more precise and helps
> monitoring.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> include/uapi/linux/snmp.h | 1 +
> net/ipv4/proc.c | 1 +
> net/ipv4/tcp_ipv4.c | 1 +
> net/ipv6/tcp_ipv6.c | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
> index 25a9ad8bcef1240915f2553a8acade447186d869..e7a31f8306903f53bc5881ae4c271f85cad2e361 100644
> --- a/include/uapi/linux/snmp.h
> +++ b/include/uapi/linux/snmp.h
> @@ -235,6 +235,7 @@ enum
> LINUX_MIB_TCPSPURIOUSRTOS, /* TCPSpuriousRTOs */
> LINUX_MIB_TCPMD5NOTFOUND, /* TCPMD5NotFound */
> LINUX_MIB_TCPMD5UNEXPECTED, /* TCPMD5Unexpected */
> + LINUX_MIB_TCPMD5FAILURE, /* TCPMD5Failure */
> LINUX_MIB_SACKSHIFTED,
> LINUX_MIB_SACKMERGED,
> LINUX_MIB_SACKSHIFTFALLBACK,
You can't add value in middle of user API enum without breaking
binary compatibility.
next prev parent reply other threads:[~2016-08-24 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 16:01 [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter Eric Dumazet
2016-08-24 17:35 ` Stephen Hemminger [this message]
2016-08-24 17:50 ` Eric Dumazet
2016-08-25 23:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824103520.56fad551@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=julieng@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox